[PATCH] Make USB disk into full DVD installer

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Make USB disk into full DVD installer

Warren Togami
<changelog>
This patch allows livecd-iso-to-disk.sh to detect if the specified .iso
image is an Anaconda DVD installer.  If so, it copies it to the USB disk
and configures syslinux to boot it.  Anaconda will automatically find
the DVD iso on the USB stick and install from it.

Requires Fedora 11 Preview DVD iso and later.
</changelog>

* This was tested to with Fedora 11 Preview DVD iso, without breaking
standard LiveCD iso install.
* Code is intentionally not "clean" in order to minimize the size of the
git diff to make it easy to visually understand and confirm the changes.
  If this patch is acceptable, it will be followed by another patch that
cleans up the code.

Comments?

Warren Togami
[hidden email]

--
Fedora-livecd-list mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/fedora-livecd-list

dvd-installer-to-usb.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Make USB disk into full DVD installer

Alan Pevec-2
On Wed, Apr 29, 2009 at 4:47 AM, Warren Togami <[hidden email]> wrote:
<changelog>
This patch allows livecd-iso-to-disk.sh to detect if the specified .iso image is an Anaconda DVD installer.  If so, it copies it to the USB disk and configures syslinux to boot it.  Anaconda will automatically find the DVD iso on the USB stick and install from it.

Requires Fedora 11 Preview DVD iso and later.
</changelog>

Wouldn't Anaconda project be a better place for this functionality? I think it's confusing to run *livecd*-iso-to-disk against non-livecd iso :)


--
Fedora-livecd-list mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/fedora-livecd-list
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Make USB disk into full DVD installer

David Huff-3
Alan Pevec wrote:

> On Wed, Apr 29, 2009 at 4:47 AM, Warren Togami <[hidden email]> wrote:
>
>> <changelog>
>> This patch allows livecd-iso-to-disk.sh to detect if the specified .iso
>> image is an Anaconda DVD installer.  If so, it copies it to the USB disk and
>> configures syslinux to boot it.  Anaconda will automatically find the DVD
>> iso on the USB stick and install from it.
>>
>> Requires Fedora 11 Preview DVD iso and later.
>> </changelog>
>>
>
> Wouldn't Anaconda project be a better place for this functionality? I think
> it's confusing to run *livecd*-iso-to-disk against non-livecd iso :)

Interesting question, I wish I read this before posting above about
livecd-to-pxeboot. What I would like to do is use livecd-to-pxeboot
script to set up pxe trees from a non-live-iso.

Although these tools are designed for livecd's I can see other uses
outside of this scenario.

It may be nice to even split the package up further, like they did with
 imgcreate, for generic livecd-tools-iso-utils....

%files iso-utils
%{_bindir}/livecd-iso-to-disk
%{_bindir}/livecd-iso-to-pxeboot

comments....

-D

--
Fedora-livecd-list mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/fedora-livecd-list
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Make USB disk into full DVD installer

Jeremy Katz
In reply to this post by Warren Togami
On Tuesday, April 28 2009, Warren Togami said:
> This patch allows livecd-iso-to-disk.sh to detect if the specified .iso  
> image is an Anaconda DVD installer.  If so, it copies it to the USB disk  
> and configures syslinux to boot it.  Anaconda will automatically find  
> the DVD iso on the USB stick and install from it.
>
> Requires Fedora 11 Preview DVD iso and later.

So I've been thinking about this all day and I really don't know that it
makes sense.  The script is explicitly for *live* images (it's in the
name! :-) and making it support more than that is just going to
complicate things.  What happens when someone then wants it to support
Ubuntu images or something else?

Also, I'm hoping to stop adding functionality to the shell script at
some point as liveusb-creator really should be preferred for most cases,
although it's command line mode needs some work

Jeremy

--
Fedora-livecd-list mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/fedora-livecd-list
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Make USB disk into full DVD installer

Warren Togami
On 04/29/2009 10:15 PM, Jeremy Katz wrote:

> On Tuesday, April 28 2009, Warren Togami said:
>> This patch allows livecd-iso-to-disk.sh to detect if the specified .iso
>> image is an Anaconda DVD installer.  If so, it copies it to the USB disk
>> and configures syslinux to boot it.  Anaconda will automatically find
>> the DVD iso on the USB stick and install from it.
>>
>> Requires Fedora 11 Preview DVD iso and later.
>
> So I've been thinking about this all day and I really don't know that it
> makes sense.  The script is explicitly for *live* images (it's in the
> name! :-) and making it support more than that is just going to
> complicate things.  What happens when someone then wants it to support
> Ubuntu images or something else?
>
> Also, I'm hoping to stop adding functionality to the shell script at
> some point as liveusb-creator really should be preferred for most cases,
> although it's command line mode needs some work
>

liveusb-creator has live in its name too!

OK, I'll write a separate script dedicated to this and a patch for
liveusb-creator too.

Warren Togami
[hidden email]

--
Fedora-livecd-list mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/fedora-livecd-list
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Make USB disk into full DVD installer

Jeremy Katz
On Wednesday, April 29 2009, Warren Togami said:

> On 04/29/2009 10:15 PM, Jeremy Katz wrote:
>> On Tuesday, April 28 2009, Warren Togami said:
>>> This patch allows livecd-iso-to-disk.sh to detect if the specified .iso
>>> image is an Anaconda DVD installer.  If so, it copies it to the USB disk
>>> and configures syslinux to boot it.  Anaconda will automatically find
>>> the DVD iso on the USB stick and install from it.
>>>
>>> Requires Fedora 11 Preview DVD iso and later.
>>
>> So I've been thinking about this all day and I really don't know that it
>> makes sense.  The script is explicitly for *live* images (it's in the
>> name! :-) and making it support more than that is just going to
>> complicate things.  What happens when someone then wants it to support
>> Ubuntu images or something else?
>>
>> Also, I'm hoping to stop adding functionality to the shell script at
>> some point as liveusb-creator really should be preferred for most cases,
>> although it's command line mode needs some work
>
> liveusb-creator has live in its name too!

Yes, but at least it's written in python so that things can be
abstracted nicely rather than the horrors of shell :-)  At which point,
maybe it should have a rename.  But I'll leave that for Luke ;-)

Jeremy

--
Fedora-livecd-list mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/fedora-livecd-list
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Make USB disk into full DVD installer

Warren Togami
On 04/29/2009 11:03 PM, Jeremy Katz wrote:
> Yes, but at least it's written in python so that things can be
> abstracted nicely rather than the horrors of shell :-)  At which point,
> maybe it should have a rename.  But I'll leave that for Luke ;-)
>
> Jeremy

Would you accept a patch for livecd-iso-to-disk.sh that detects if the
ISO is an anaconda installer and prints a helpful message?  Otherwise it
appears to succeed like it does now, while being not useful.

Warren

--
Fedora-livecd-list mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/fedora-livecd-list
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Make USB disk into full DVD installer

Jeremy Katz
On Thursday, April 30 2009, Warren Togami said:
> On 04/29/2009 11:03 PM, Jeremy Katz wrote:
>> Yes, but at least it's written in python so that things can be
>> abstracted nicely rather than the horrors of shell :-)  At which point,
>> maybe it should have a rename.  But I'll leave that for Luke ;-)
>
> Would you accept a patch for livecd-iso-to-disk.sh that detects if the  
> ISO is an anaconda installer and prints a helpful message?  Otherwise it  
> appears to succeed like it does now, while being not useful.

Better to check that the image is "supported" (ie, is a live image)
rather than the converse.  But then I'd be okay with it

Jeremy

--
Fedora-livecd-list mailing list
[hidden email]
https://www.redhat.com/mailman/listinfo/fedora-livecd-list